Skip to content

Add TorchAO wrapper config to allow filter_fn for quantize_ #13264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add TorchAO wrapper config to allow filter_fn for quantize_ #13264

wants to merge 4 commits into from
+118 −54

Conversation

abhinaykukkadapu
Copy link
Contributor

@abhinaykukkadapu abhinaykukkadapu commented Aug 10, 2025 •
edited
Loading

Changes:

  1. Support filter function in quantize_ function when using torchao quantize.
  2. Update unittests accordingly
  3. Use ComposableQuantizer if there are multiple quantizers and is of type torchao, for legacy quantizers use them directly with prepare_pt2e.
  4. Source transform modifies model inplace, so deep copy first to avoid modifying user provided model.

@abhinaykukkadapu
Update
59affe6 
[ghstack-poisoned]
@abhinaykukkadapu
Copy link
Contributor Author

abhinaykukkadapu commented Aug 10, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 10, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13264

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures

As of commit 7dab762 with merge base a84b3c9 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 10, 2025
@abhinaykukkadapu abhinaykukkadapu mentioned this pull request Aug 10, 2025
Open
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@abhinaykukkadapu
Update
37bdc0b 
[ghstack-poisoned]
@abhinaykukkadapu
Update
4eb6a03 
[ghstack-poisoned]
@abhinaykukkadapu
Update
7dab762 
[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

@metascroy metascroy Awaiting requested review from metascroy

@mcr229 mcr229 Awaiting requested review from mcr229 mcr229 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abhinaykukkadapu